eth/protocols/snap: speed up hash checks#22023
Merged
Merged
Conversation
karalabe
reviewed
Jan 7, 2021
Member
There was a problem hiding this comment.
hash := make([]byte, 32), Go usually either uses var for the default value or := for non defaults. Pls also add a newline after this.
Pls update the others too.
9 tasks
9 tasks
This was referenced Sep 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR optimises the hashing a bit during the snap response verification. We use a
hashonly temporarily, to verify against the request, and can thus reuse the same buffer, and avoid an alloc and copy. We can also use thekeccatStateto avoid a second alloc+copy viaReadinstead ofSum.Benchmark for checking
10Kitems with 100 bytes of data each: